3 Commits

Include renames

Author	SHA1	Message	Date
inliver233	1dc1d9b707	Fix the command gate's blind spot, and make --json actually be JSON ... A reviewer reported seven drifting commands in the evidence record. Reproduced, the report split three ways, and the middle category was the useful one: the gate had been scoring them clean. Not reproducible, with the measurement: tests/run_tests.py -q runs. The wrapper forwards its arguments to pytest (`args = list(argv[1:]) or ["-q"]`), and documents that in its own usage. dcc.py already written as `cd tools/_work/bench/repos/dcc` followed by `python dcc.py ...` -- an external checkout, not a shipped script. Real, and fixed here: seven commands in two evidence records named a **workbench** script with no path at all (`analyze_pair.py`, `make_skeleton.py`, `ttd_attach.py`, `b2_measure.py`). The files exist under `tools/`, which .gitignore excludes, so a reader copying one from the repository root gets "No such file" -- and two of those documents wrote the correct path elsewhere, so they disagreed with themselves. **The actual defect was in `check_commands.py`, not in the seven lines.** `resolve_script()` tried the document's own directory first, so a bare `analyze_pair.py` inside `docs/tool-verification/` resolved to `tools/_work/bench/unpack/b3/analyze_pair.py` -- a real file -- and passed. Resolution now follows the order a reader would try (repository root, then the skill's scripts, then the document's own directory, which is what `../x.py` in a nested README legitimately means); a bare name that only resolves under `tools/` is `unqualified-workbench`; and that class counts as **drift, not as a skip**, because it is a one-token fix that a reader cannot run. The first attempt classified it as a low-confidence warning, which would have left all seven in place. One exception is honoured and pinned: a code block opening with `cd tools/_work/bench/repos/dcc` is telling the reader where to stand, so a bare `python dcc.py` after it is correct. `documented_commands()` now reports whether a `cd` preceded the command in the same block, and that case is skipped as `workbench-after-cd`. Two defects of this pass's own, found while fixing it: --json emitted the RESULT= token after the JSON document, so `--json | jq` failed with "Extra data". The token is gone from that path; the status is a field in the document, and the exit code carries the same meaning. The fix's own substitution left four literal backslashes before `$` in the two files it edited -- a character a reader would copy by mistake. Removed, and verified absent. `tests/integration/test_check_commands_gate.py` pins the resolution order, the drift classification, the `cd` exception, and a clean pass over the committed tree, so this cannot come back silently. Gates: check_commands 153 checked / 0 drift, check_repo 0 problem, check_refs 0 dangling / 0 warning, check_routing coherent, check_budget 0 failure / 0 warning, pytest 613 passed / 158 skipped / 25 xfailed.	2026-09-22 02:18:40 +08:00
inliver233	d0fe0ea337	Harden the path audit, generalise three absolute paths, and gate the corpus size ... An external review found the evidence record honest and the gates real, but raised three concrete defects. Each is fixed at its cause rather than at its symptom, and the reasoning is recorded in docs/tool-verification/REPO-DECISIONS.md. build_scripts.py -- the audit reported 37 findings, most of them noise It matched any `X:\...` literal, so `C:\Program Files\...`, `C:\Python314\...` and literal placeholders all counted as machine-specific leftovers. A gate whose output is mostly noise stops being read -- the same failure scan_leaks.py names when it refuses to exempt the RFC 5737 ranges. Two explicit exemption families are added instead of a looser regex: GENERIC_PATH_PREFIXES (install locations that exist on every host of that platform) and `_leaks_nothing()` (also exempts an already-redacted path, since a placeholder or an ellipsis means a normalisation pass already ran). Two traps surfaced only because the change was tested rather than merely run. BARE_ABS stops at whitespace, so `C:\Program Files\...` arrives truncated as `C:\Program` and a one-way `startswith` misses the exemption; the comparison is now bidirectional under a minimum length. And with a lookahead of only `[a-z0-9]` the optional `\\?` backtracks to empty, the next character is the separator, it passes, and a real personal path is swallowed -- the lookahead has to exclude the separator as well. Both were caught by the case table, not by the audit run. Result: 37 -> 0 findings, exit 2 -> exit 0. The real hits (`E:\apk-reverse\...`, `E:\agb_apktool.jar`) were fixed in the documents, not by widening the list. Three absolute paths on the published surface EXTENSION-desensitization.md, EXTENSION-extraction-shell-bench.md and EXTENSION-vmp-diff.md quoted a workbench root, a tool jar and an SDK location absolutely. docs/tool-verification/ already states the rule -- a record may say a run happened at a `tools/...` path, written relatively -- so the three files were made to match the rule they were already under. The tool-jar and SDK cases are rephrased rather than placeholder-ised, so no reader has to learn a new token. check_budget.py -- blind to the half of the problem it was not measuring The gate budgets the always-loaded part and could not see the corpus, where a new reference costs exactly one index line: the corpus can double while the narrative count stays green. Two note-level thresholds now report it. Notes, not failures -- a large corpus is a choice, a growth nobody measured is the defect. The first run reports 47 references + 55 scripts = 102 files, 31,423 lines. A cross-tool inconsistency this pass ran into, recorded rather than papered over build_scripts.py now exempts any `<...>` placeholder; scan_leaks.py recognises a fixed token list. An invented placeholder in a source comment passed the first and was read by the second as the very personal name its `user_path_windows` rule exists to catch, turning check_repo.py red. That is by design -- a strict list is what stops a real name hiding behind a plausible-looking placeholder -- but the two tools disagree about what "already redacted" means, and the disagreement stays invisible until someone writes a new token. Rephrased here; a future pass may want one shared list. Verification - build_scripts.py: 37 -> 0 findings on a clean clone, exit 0. - An 18-case table pins both directions, 0 failures: generic and already-redacted paths are exempt, while a real workbench path, a real personal name after `C:\Users\`, a real POSIX home and a real project path still report. It found two defects in the first implementation. - All four gates pass: check_repo 0 problem, check_refs 0 dangling / 0 warning, check_budget 0 failure / 0 warning / 3 notes, build_scripts 0 findings.	2026-09-21 23:18:17 +08:00
inliver233	6221a072ca	Benchmark pass: measure the documented routes, close five tool gaps, correct four claims ... Public targets under the existing routes, recorded per row in tests/benchmark.md with each row's own strength label: the MASTG crackmes (equal-length patch -> repack -> re-sign with a zero-change control, and the anti-debug race with its time-to-death baseline), DexPatcher's ezAndroid sample, two real split APK sets, and a self-built extraction-skeleton set. Hardening-shape discrimination now separates Java2C from an extraction shell, a VMP and JNI sinking. New: java2c_probe.py and java2c-and-jni-sinking.md; split-apk.md with repack.py growing set inventory, unified re-signing and merge; protobuf_decode_raw.py cross-checked against the official runtime; vmp_diff_harness.py and its cost table; kernelsu_syscall_mask.py with three kernel-side templates; stalker_trace.js gains Stalker.exclude() and a zero-event warning. Corrections, each because a measurement contradicted a recorded conclusion: the trivial-body ratio is bimodal rather than a threshold and the old threshold claim was deleted; a Dex-VMP verdict was withdrawn after dexdump contradicted a hand-written opcode table; the assumption that Stalker.exclude() fixes zero-event delivery is disproved (it keeps the process alive, nothing more); and a repack.py signing-path claim expired mid-pass when a second writer added one. Emulated and kernel-side routes are labelled unverified where no toolchain or device could run them; each evidence file states what was not run.	2026-09-21 21:57:23 +08:00